Shawyeok opened a new pull request #3156: URL: https://github.com/apache/bookkeeper/pull/3156
### Motivation The disk usage metric and the number of writable directories about ledger directories is duplicated cause `LedgerDirsManager` was created with same ledgerDir more than once, here it is: 1. with `bookie_ledger` scope https://github.com/apache/bookkeeper/blob/38dc3281f5f175a7d194d4c0d4b255472886187b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java#L365-L366 2. with `bookie` score https://github.com/apache/bookkeeper/blob/38dc3281f5f175a7d194d4c0d4b255472886187b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java#L155 The second one wasn't bind with a `DiskChecker`, so it's metric never changes. ### Changes Remove second one, remove metrics below: - `bookie_dir_<ledger directory>_usage` - `bookie_writable_dirs` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
