nicoloboschi opened a new pull request #3160:
URL: https://github.com/apache/bookkeeper/pull/3160


   ### Motivation
   If you run spotbugs with JDK8 it fails on bookkeper-server in this way:
   >Error:  Exception is caught when Exception is not thrown in 
org.apache.bookkeeper.proto.checksum.DirectMemoryCRC32Digest.<static 
initializer for DirectMemoryCRC32Digest>() 
[org.apache.bookkeeper.proto.checksum.DirectMemoryCRC32Digest] At 
DirectMemoryCRC32Digest.java:[line 86] REC_CATCH_EXCEPTION
   
   I don't think it makes much sense. The "official" suggestion is to [have 
separated catch 
clauses](http://findbugs.sourceforge.net/bugDescriptions.html#REC_CATCH_EXCEPTION)
   
   We didn't notice it on master because during the Maven restore we 
accidentaly lost the spotbugs execution but it's still on branch-4.14
   
   ### Changes
   * Fix spotbugs
   * Restore spotbugs check w/ jdk8 on CI 
   
   We'll need to cherry-pick to branch-4.14 to fix the compilation on jdk8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to