nicoloboschi commented on code in PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#discussion_r854197733
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/datainteg/DataIntegrityCookieValidation.java:
##########
@@ -96,7 +96,7 @@ private void stampCookie(Cookie masterCookie, Version
expectedVersion, List<File
log.info("Stamping cookie to directory {}", d);
masterCookie.writeToDirectory(d);
} catch (IOException ioe) {
- log.error("Exception writing cookie to {}", ioe);
+ log.error("Exception writing cookie to ", ioe);
Review Comment:
```suggestion
log.error("Exception writing cookie", ioe);
```
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java:
##########
@@ -151,7 +151,7 @@ && checkAuthPlugin(req.getAuthRequest(), ctx.channel())) {
private boolean checkAuthPlugin(AuthMessage am, final Channel src) {
if (!am.hasAuthPluginName() ||
!am.getAuthPluginName().equals(authProviderFactory.getPluginName())) {
LOG.error("Received message from incompatible auth plugin.
Local = {}," + " Remote = {}, Channel = {}",
Review Comment:
can we remove the concatenation ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
