hangc0276 commented on PR #3197: URL: https://github.com/apache/bookkeeper/pull/3197#issuecomment-1111663218
> * fields and method params should use interface instead of concrete implementation @dlg99 Thanks you for your patient review. > * fields and method params should use interface instead of concrete implementation For current purposes, we will support dbLedgerStorage to use directIOEntryLogger first, and for other kind ledgerStorage implementation, we will consider to support later. For other kinds of ledgerStorage support, we should do more work on the EntryLogger interface abstraction in the future. So my suggestion is that currently we use `DefaultEntryLogger` for the fields and method params in other kinds of ledgerStorage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
