hangc0276 commented on PR #3263: URL: https://github.com/apache/bookkeeper/pull/3263#issuecomment-1153142010
> > The biggest difference is the padding. Direct I/O must write in aligned blocked. > > Another difference in the format is that the header is now 4K rather than 1K. Again, this is to allow aligned rights. No changes are necessary to allow the existing entry logger to deal with the header change, as we create a dummy entry in the extra header space that the existing entry logger already knows to ignore. > > I think this calls to addition of backwards-compat tests, upgrade/downgrade scenario (data written with these changes can be read by previous version of BK and vice versa) > > https://github.com/apache/bookkeeper/tree/master/tests/backward-compat Ok, I will add the backwards-compact tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
