merlimat commented on code in PR #3342:
URL: https://github.com/apache/bookkeeper/pull/3342#discussion_r899818425


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java:
##########
@@ -161,7 +164,7 @@ public SingleDirectoryDbLedgerStorage(ServerConfiguration 
conf, LedgerManager le
         this.writeCacheMaxSize = writeCacheSize;
         this.writeCache = new WriteCache(allocator, writeCacheMaxSize / 2);
         this.writeCacheBeingFlushed = new WriteCache(allocator, 
writeCacheMaxSize / 2);
-
+        this.writeCacheLastFlushed = new WriteCache(allocator, 
writeCacheMaxSize / 2);

Review Comment:
   This will make us use 150% of the configured memory for the write cache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to