merlimat commented on code in PR #3350:
URL: https://github.com/apache/bookkeeper/pull/3350#discussion_r903065933
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -1026,7 +1026,11 @@ public PlacementPolicyAdherence
isEnsembleAdheringToPlacementPolicy(List<BookieI
for (int j = 0; j < writeQuorumSize; j++) {
bookie = ensembleList.get((i + j) % ensembleSize);
try {
-
racksInQuorum.add(knownBookies.get(bookie).getNetworkLocation());
+ if (knownBookies.containsKey(bookie)) {
+
racksInQuorum.add(knownBookies.get(bookie).getNetworkLocation());
Review Comment:
nit: we could check on the map one single time:
```java
String kb = knownBookies.get(bookie);
if (kb != null) {
///...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
