horizonzy commented on code in PR #3354:
URL: https://github.com/apache/bookkeeper/pull/3354#discussion_r905626699
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -1026,7 +1026,14 @@ public PlacementPolicyAdherence
isEnsembleAdheringToPlacementPolicy(List<BookieI
for (int j = 0; j < writeQuorumSize; j++) {
bookie = ensembleList.get((i + j) % ensembleSize);
try {
-
racksInQuorum.add(knownBookies.get(bookie).getNetworkLocation());
+ BookieNode bookieNode = knownBookies.get(bookie);
+ if (bookieNode == null) {
+ bookieNode = historyBookies.get(bookie);
Review Comment:
If the knownBookies didn't hold bookie, it will thown NPE. Can't resolve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
