[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files

[GitBox]

StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168170737

   > I can't understand where the user configures this feature.
   > 
   > is it backward compatible ?
   
   it's the different api : 
   this is junit 5, import by org.junit.jupiter.api: 
   <img width="651" alt="image" 
src="https://user-images.githubusercontent.com/42990025/176084498-5f3dee80-45b7-4018-b0cd-fae9b3053c63.png";>
   <img width="629" alt="image" 
src="https://user-images.githubusercontent.com/42990025/176084261-ffb9efe2-2b66-41e2-98f0-5d75f3c3f208.png";>
   
   old junit 4,import by org.junit
   <img width="651" alt="image" 
src="https://user-images.githubusercontent.com/42990025/176084505-7d38ff86-4cc8-4041-9541-588b56e6e16c.png";>
   <img width="404" alt="image" 
src="https://user-images.githubusercontent.com/42990025/176084460-c13f2c6b-d72e-4375-be09-0072788209e2.png";>
   
   I think it's not necessary to expand here. we can start a mail to discuss 
this for bookkeeper's testcase. @eolivelli @Shoothzj 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org