[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3376: fix testcase problem: always run fail for zk connect

Thu, 30 Jun 2022 20:41:53 -0700 


StevenLuMT commented on code in PR #3376:
URL: https://github.com/apache/bookkeeper/pull/3376#discussion_r911590812


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/conf/TestBKConfiguration.java:
##########
@@ -61,9 +61,9 @@ public static ServerConfiguration newServerConfiguration() {
         confReturn.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, 4);
         confReturn.setProperty(DbLedgerStorage.READ_AHEAD_CACHE_MAX_SIZE_MB, 
4);
         /**
-         * if testcase has zk error,just try 0 time for fast running
+         * if testcase has zk error,just try 3 time for fast running
          */
-        confReturn.setZkRetryBackoffMaxRetries(0);
+        confReturn.setZkRetryBackoffMaxRetries(3);

Review Comment:
   @hangc0276  set zkRetryBackoffMaxRetries to Integer.MAX_VALUE is ok, I have 
changed it ,thanks
   <img width="2496" alt="image" 
src="https://user-images.githubusercontent.com/42990025/176818886-0a47bd6b-ceb0-4c5c-b60c-fcd430930c7e.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to