dlg99 commented on PR #3383:
URL: https://github.com/apache/bookkeeper/pull/3383#issuecomment-1175204096

   > In the tests there is no negative in keeping this even in cases where 
syscall overhead is not dominant
   
   @merlimat can you share the test results with/without the change? e.g. under 
high/low load scenarios.
   
https://github.com/netty/netty/commit/e3c8a924993018e5d8e7d724fc89cc1f9d691387 
says "The only "downside" may be a bit higher latency in the case of where only 
one flush is triggered by the user."
   Unfortunately it is not obvious how much higher is "a bit higher" and how it 
is affected by choice of parameters (1024 in current case vs 256 used by the 
handler as default)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to