dlg99 commented on code in PR #3390:
URL: https://github.com/apache/bookkeeper/pull/3390#discussion_r915285111
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -547,6 +549,9 @@ void doCompactEntryLogs(double threshold, long
maxTimeMillis) throws EntryLogMet
MutableLong end = new MutableLong(start);
MutableLong timeDiff = new MutableLong(0);
+ PriorityQueue<EntryLogMetadata> pq = new PriorityQueue<>(Comparator
Review Comment:
I changed this to compact by bucket (from lowest to highest, still
prioritizes most compactable entry logs).
As an overhead, it will keep entry log ids in memory. With 50TB disk and
250MB entry log, all entry logs below threshold that's about 200k longs to keep
in memory, we should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
