hangc0276 commented on code in PR #3406:
URL: https://github.com/apache/bookkeeper/pull/3406#discussion_r922078647
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcherImpl.java:
##########
@@ -17,7 +17,7 @@
*/
package org.apache.bookkeeper.client;
-import static
org.apache.bookkeeper.bookie.BookKeeperServerStats.ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNTER;
+import static
org.apache.bookkeeper.bookie.BookKeeperServerStats.ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNT;
Review Comment:
Do we need to use `TOTAL` suffix instead of `COUNT` according to the new
rules?
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java:
##########
@@ -148,15 +148,15 @@ public interface BookKeeperServerStats {
String LEDGER_CACHE_MISS = "LEDGER_CACHE_MISS";
// Compaction/Garbage Collection Related Counters
- String ACTIVE_ENTRY_LOG_COUNT = "ACTIVE_ENTRY_LOG_COUNT";
+ String ACTIVE_ENTRY_LOG_COUNT = "ACTIVE_ENTRY_LOG_TOTAL";
Review Comment:
Do we need to keep the variable name sync with the metric name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
