dlg99 commented on PR #2931: URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1190559164
I have rather generic comments. > If the bookie cluster has remained bookies which place to /region/rack1, the ledger recovers to the /region/rack1 bookie again. As I understand, there is enforceMinNumRacksPerWriteQuorum option to prevent that (and enforceMinNumFaultDomainsForWrite, enforceStrictZoneawarePlacement for other placement policies) As I understand, Auditor's placementPolicyCheck just detects the problem. Maybe it makes sense to make Auditor (optionally) put the ledgers with bad placement for re-replication and make AutoRecovery handle that? In this case the CLI command is already existing triggeraudit. Another note is that the test only covers rack-aware policy. What happens in case of the region-aware or zone-aware policies? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
