eolivelli commented on code in PR #3415:
URL: https://github.com/apache/bookkeeper/pull/3415#discussion_r926279404
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java:
##########
@@ -41,18 +43,92 @@
/**
* Test bookie expiration.
*/
+@Slf4j
public class BookieZKExpireTest extends BookKeeperClusterTestCase {
public BookieZKExpireTest() {
super(0);
- // 6000 is minimum due to default tick time
- baseConf.setZkTimeout(6000);
- baseClientConf.setZkTimeout(6000);
}
+ /*
+ Should recover from request timeout.
+ */
+ @Test
@SuppressWarnings("deprecation")
+ public void testBookieServerZKRequestTimeoutBehaviour() throws Exception {
+ // 6000 is minimum due to default tick time
+ System.setProperty("zookeeper.request.timeout", "6000");
Review Comment:
We have to do System.clearProperty in a finally block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
