Shoothzj commented on code in PR #3285:
URL: https://github.com/apache/bookkeeper/pull/3285#discussion_r927283344
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java:
##########
@@ -229,5 +231,18 @@ private void checkDirs(final LedgerDirsManager ldm)
}
ldm.getWritableLedgerDirs();
}
+
+ @VisibleForTesting
+ void setDiskSpaceThreshold(float diskSpaceThreshold, float
diskUsageLwmThreshold) {
Review Comment:
do we really need this method? can we instantiate a LedgerDirsMonitor to run
tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
