hangc0276 commented on PR #3194: URL: https://github.com/apache/bookkeeper/pull/3194#issuecomment-1194176266
> @hangc0276 thanks for your contribution at first. I left one small comment, please check it. From the change, I can see that the main changes is that extract `writeHeader` and allow to writeHeader to existing file if it exists and `skipHeader` when scanning the journal file to replace current `fileExists` trigger, correct me if I'm wrong. @ArvinDevel Thanks for your review. Yes, you are right. The original logic is a little complex and it has bugs. I rewrite the logic, Please help take a look again. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
