hangc0276 commented on code in PR #2887:
URL: https://github.com/apache/bookkeeper/pull/2887#discussion_r929848046
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java:
##########
@@ -849,12 +852,13 @@ public void run() {
public int shutdown() {
return shutdown(ExitCode.OK);
}
-
// internal shutdown method to let shutdown bookie gracefully
// when encountering exception
- synchronized int shutdown(int exitCode) {
+ ReentrantLock lock = new ReentrantLock(true);
+ int shutdown(int exitCode) {
Review Comment:
Why use `ReentrantLock` instead of `synchronized` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
