horizonzy commented on PR #3001: URL: https://github.com/apache/bookkeeper/pull/3001#issuecomment-1195631211
And there is a more suitable value for it. In we use `DbLedgerStorage`, it will occupy 1/2 unpooled direct memory for write cache and read cache, it's unpooled but occupy direct memory, we shuold consider it. When we calculate the concurrency, we should subtract the memory which writeCache and readCache total occupy. See: https://github.com/apache/bookkeeper/blob/39a9c281a6ab329ba1aa8fb232ce81c2ad6719cc/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java#L153-L156. https://github.com/apache/bookkeeper/blob/39a9c281a6ab329ba1aa8fb232ce81c2ad6719cc/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/WriteCache.java#L116 https://github.com/apache/bookkeeper/blob/39a9c281a6ab329ba1aa8fb232ce81c2ad6719cc/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/ReadCache.java#L79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
