eolivelli commented on code in PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#discussion_r930967010
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/EventLoopUtil.java:
##########
@@ -47,6 +47,10 @@ public static EventLoopGroup
getServerEventLoopGroup(ServerConfiguration conf, T
return getEventLoopGroup(threadFactory, conf.getServerNumIOThreads(),
conf.isBusyWaitEnabled());
}
+ public static EventLoopGroup getServerAcceptorGroup(ServerConfiguration
conf, ThreadFactory threadFactory) {
+ return getEventLoopGroup(threadFactory,
conf.getServerNumAcceptorThreads(), conf.isBusyWaitEnabled());
Review Comment:
does BusyWaitEnabled apply to the acceptor group ?
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java:
##########
@@ -118,10 +119,14 @@ class BookieNettyServer {
this.authProviderFactory =
AuthProviderFactoryFactory.newBookieAuthProviderFactory(conf);
if (!conf.isDisableServerSocketBind()) {
- this.eventLoopGroup = EventLoopUtil.getServerEventLoopGroup(conf,
new DefaultThreadFactory("bookie-io"));
+ this.eventLoopGroup = EventLoopUtil.getServerEventLoopGroup(conf,
+ new DefaultThreadFactory("bookie-io"));
+ this.acceptorGroup = EventLoopUtil.getServerAcceptorGroup(conf,
Review Comment:
aren't we shutting down this group ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
