equanz commented on code in PR #2931:
URL: https://github.com/apache/bookkeeper/pull/2931#discussion_r938418581
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java:
##########
@@ -236,6 +236,28 @@ public BookieNode selectFromNetworkLocation(
}
}
+ @Override
+ public PlacementResult<List<BookieId>> replaceToAdherePlacementPolicy(
Review Comment:
> Maybe we can list the kinds of replace result, and pick the "minimize"
result.
Yeah.
I think, alternatively, if the minimization is too costly for calculation,
reduce as much as possible in a realistic amount of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
