horizonzy commented on PR #2931: URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206280009
>> I notice that the implements didn’t handle the bookie which already shutdown. The shutdown bookie will be as the defaultRack, can we replace it? > If the default rack name is /default-rack, then we can't add it. https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763f0d3f6115a066fcabe9/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/NetworkTopologyImpl.java#L416-L420 I means the `defaultRack` is not literal, I means the `defaultRack` is `/default-region/default-rack`. 😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
