michaeljmarshall commented on issue #3442:
URL: https://github.com/apache/bookkeeper/issues/3442#issuecomment-1210134353

   We could expose the metrics by adding these methods to the 
`KeyValueStorageRocksDB` class.
   
   ```java
       public long cacheMisses() throws IOException {
           return statistics.getTickerCount(TickerType.BLOCK_CACHE_MISS);
       }
   
       public long cacheHits() throws IOException {
           return statistics.getTickerCount(TickerType.BLOCK_CACHE_HIT);
       }
   ```
   
   We might have trouble integrating them with the current `StatsLogger` 
because there is no way to register counters. If you look at the 
`EntryLocationIndexStats`, you'll see that it relies on registering a gauge. 
These metrics are not gauges though, so it could lead to some minor confusion 
when interpreting the metrics output.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to