lhotari commented on PR #3444: URL: https://github.com/apache/bookkeeper/pull/3444#issuecomment-1212256336
> We already have the index lookup stats `read-locations-index-time`, does it has any case this metric can't cover? > > https://github.com/apache/bookkeeper/blob/de5d45fb823dc558f15bcb9d958b9c0a5144043c/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageStats.java#L48 thanks for pointing that out @hangc0276 . The problem with the `read-locations-index-time` is that it's not a latency metric. it's a counter metric that records the total time spent for `getLocationIndex` calls. I also noticed that the metric is not used for the getLocation call in entryExists method: https://github.com/apache/bookkeeper/blob/4ee8c0411878689417c39b7027899ed7ce815e7e/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java#L344-L348 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
