chenBright commented on issue #2696: URL: https://github.com/apache/brpc/issues/2696#issuecomment-5433653926
> What's the current status of your rotation plan — do you already have an implementation, or is this open for someone else to take? I haven't implemented rotation yet; I look forward to your PR! > Would you rather see the LogStream/LogStreamFactory refactor land first? There are currently no plans to refactor LogStream/LogStreamFactory. No need to wait. > I'd lean towards documenting multi-process shared log files as unsupported for rotation rather than adding flock, but I'd rather follow your preference here. I agree with you. @cw20050111-prog Looking forward to your PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
