[
https://issues.apache.org/jira/browse/CALCITE-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999619#comment-14999619
]
Julian Hyde commented on CALCITE-959:
-------------------------------------
I think you should deprecate the original constructor (mark it 'to be removed
before 2.0), and add a simple javadoc comment to the new constructor. With
those changes +1, go ahead and commit. (You don't need the " (Maryann Xue)"
commit suffix now you're a committer.)
> Add a constructor for SortProjectTransposeRule with desciption
> --------------------------------------------------------------
>
> Key: CALCITE-959
> URL: https://issues.apache.org/jira/browse/CALCITE-959
> Project: Calcite
> Issue Type: Improvement
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Priority: Minor
> Fix For: 1.6.0
>
> Attachments: CALCITE-959.patch
>
>
> Since the default instance only matches LogicalProject.class (and it would be
> problematic to match Project.class), it might be nice to provide a
> constructor that takes an extra description string to allow users to have
> another instance of this rule in addition to the default one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
