[
https://issues.apache.org/jira/browse/CALCITE-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025865#comment-15025865
]
Julian Hyde commented on CALCITE-991:
-------------------------------------
I presume that you want to add SqlFunctionCategory values because
SqlOperatorTable.lookupOperatorOverloads is your interface of choice? But it
doesn't help with Schema.getFunctions(String), right?
Some review comments:
* How about converting {{SqlFunctionCategory.isSpecific()}} (and similar
methods) into a final boolean field?
* {{isUnresolvedUserDefinedFunction}} is misleadingly named.
* {{isUserdefined}} is mis-spelled.
* Why would anyone create a SqlUserDefinedFunction whose category is not
USER_DEFINED_FUNCTION?
* In CalciteCatalogReader can you use {{Iterables.filter}}? {{Iterator.remove}}
always gives me the creeps.
* Please run checkstyle and fix the format of the commit string.
> Create separate SqlFunctionCategory values for table functions and macros
> -------------------------------------------------------------------------
>
> Key: CALCITE-991
> URL: https://issues.apache.org/jira/browse/CALCITE-991
> Project: Calcite
> Issue Type: Improvement
> Reporter: Julien Le Dem
> Assignee: Julian Hyde
>
> This avoids trying to apply a table function in a context where it does not
> apply or a regular function where a table function is needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
