[
https://issues.apache.org/jira/browse/CALCITE-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025975#comment-15025975
]
Julien Le Dem edited comment on CALCITE-991 at 11/25/15 1:59 AM:
-----------------------------------------------------------------
Yes, eventually I'd like the FunctionCategory to be passed to getFunctions (or
some other mechanism). But this seemed like a reasonable first step.
- about the boolean field: Yes. However it sometimes becomes hard to read when
you have several fields. As everything is defined in the body of the enum I
find the current definition more readable. If you like the boolean field better
I'll change it.
- isUnresolvedUserDefinedFunction: I did not have a good name. Suggestions?
- isUserdefined: Will fix
- SqlUserDefinedFunction: The existing hierarchy was a little confusing to me.
TableUserDefinedFunction extends it. We can change this.
- Iterables.filter: will do
- checkstyle : will do
was (Author: julienledem):
- about the boolean field: Yes. However it sometimes becomes hard to read when
you have several fields. As everything is defined in the body of the enum I
find the current definition more readable. If you like the boolean field better
I'll change it.
- isUnresolvedUserDefinedFunction: I did not have a good name. Suggestions?
- isUserdefined: Will fix
- SqlUserDefinedFunction: The existing hierarchy was a little confusing to me.
TableUserDefinedFunction extends it. We can change this.
- Iterables.filter: will do
- checkstyle : will do
> Create separate SqlFunctionCategory values for table functions and macros
> -------------------------------------------------------------------------
>
> Key: CALCITE-991
> URL: https://issues.apache.org/jira/browse/CALCITE-991
> Project: Calcite
> Issue Type: Improvement
> Reporter: Julien Le Dem
> Assignee: Julian Hyde
>
> This avoids trying to apply a table function in a context where it does not
> apply or a regular function where a table function is needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
