[
https://issues.apache.org/jira/browse/CALCITE-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032408#comment-15032408
]
Jinfeng Ni commented on CALCITE-966:
------------------------------------
[~julianhyde], thanks for the reminding and review comments. I revised the PR
based on your comments.
Somehow, I remember you said the new unit test failed on windows. But I just
could not find a windows machine to see what's going on. I looked the comments
on PR, and did not see the mentioning of failure on windows. If it still fails
on windows, please let me know; I'll try to borrow a windows instance to run
the test. Thanks.
> VolcanoPlanner should clear ruleNames in order to avoid rule name conflicting
> error
> -----------------------------------------------------------------------------------
>
> Key: CALCITE-966
> URL: https://issues.apache.org/jira/browse/CALCITE-966
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Jinfeng Ni
> Assignee: Jinfeng Ni
> Priority: Minor
> Fix For: 1.6.0
>
>
> When VolcanoPlanner is called multiple times through Frameworks, it may
> encounter rule name conflicting error, if the first ruleset and second
> ruleset have rules with identical name.
> The fix is to simply clear the set of ruleNames in VolcanoPlanner.clear()
> method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
