[
https://issues.apache.org/jira/browse/CALCITE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081808#comment-15081808
]
Julian Hyde commented on CALCITE-1038:
--------------------------------------
I decided to obsolete AggregateConstantKeyRule, moving its functionality into
AggregateProjectPullUpConstantsRule.
We now detect constants using metadata (RelMdPredicates). The input does not
need to be a Project, and constants do not need to be literals.
> Combine AggregateProjectPullUpConstantsRule and AggregateConstantKeyRule
> ------------------------------------------------------------------------
>
> Key: CALCITE-1038
> URL: https://issues.apache.org/jira/browse/CALCITE-1038
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
>
> Following CALCITE-1023, AggregateConstantKeyRule is a superset of
> AggregateProjectPullUpConstantsRule because it matches any RelNode whose
> output columns are constants, not just a Project.
> This task is to check that AggregateConstantKeyRule does indeed have all
> required functionality, convert test cases to use it, mark
> AggregateProjectPullUpConstantsRule deprecated, and remove as much of its
> code as possible.
> Or to obsolete AggregateConstantKeyRule if that is easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
