[ 
https://issues.apache.org/jira/browse/CALCITE-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde resolved CALCITE-955.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 1.6.0

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/9a52b5ed.

> Litmus, continuation-passing style applied to validation methods
> ----------------------------------------------------------------
>
>                 Key: CALCITE-955
>                 URL: https://issues.apache.org/jira/browse/CALCITE-955
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>             Fix For: 1.6.0
>
>
> Calcite has several methods that check internal consistency that have a 
> 'boolean fail' argument indicating whether the method should throw or just 
> return false if a consistency error is detected.
> We propose to add a class Litmus:
> {code}interface Litmus {
>   boolean fail(String message);
>   boolean succeed();
> }{code}
> and replace those {{boolean fail}} with {{Litmus litmus}}, so that the caller 
> can determine policy on how to handle failures.
> Methods affected include:
> * RelNode.isValid(boolean)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to