[
https://issues.apache.org/jira/browse/CALCITE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092966#comment-15092966
]
Jason Altekruse edited comment on CALCITE-978 at 1/12/16 12:06 AM:
-------------------------------------------------------------------
[~julianhyde] As I understand what you are saying, this would prevent the rule
from being run in the cases where the current functionality is not desired, as
is the case with Drill's late types.
What I was trying to do with this change was reuse most of the rule and just
allow customizing the behavior where it is swapping out a subtree for a values
operator. We could just copy the rule in Drill and give it the behavior that we
want and not include the default calcite one.
Many of the changes in the patch have already been made in master (making the
classes not anonymous caused much of the diff ugliness). I have pushed a branch
with the small change that I actually need to make for our existing strategy to
work. Let me know if this seems reasonable.
was (Author: jaltekruse):
[~julianhyde] As I understand what you are saying, this would prevent the rule
from being run in the cases where the current functionality is not desired, as
is the case with Drill's late types.
What I was trying to do with this change was reuse most of the rule and just
allow customizing the behavior where it is swapping out a subtree for a values
operator. We could just copy the rule in Drill and give it the behavior that we
want and not include the default calcite one.
Much of the changes in the patch have already been made in master (making the
classes not anonymous). I have pushed a branch with the small change that I
actually need to make for our existing strategy to work. Let me know if this
seems reasonable.
> Make ReduceExpressionsRule extensible to transform false filter in
> schema-on-read case
> ---------------------------------------------------------------------------------------
>
> Key: CALCITE-978
> URL: https://issues.apache.org/jira/browse/CALCITE-978
> Project: Calcite
> Issue Type: Bug
> Reporter: Jinfeng Ni
> Assignee: Jason Altekruse
> Labels: drill
>
> This comes from a commit in Drill's forked Calcite
> (https://github.com/dremio/calcite/commit/a29f007f4f4017368b6f41bf8c3aba4490a1cee8).
> ReduceExpressionRule will transform a false filter into VALUES with empty
> input. This only works in the case of schema-aware scenario. In
> schema-on-read scenario like Drill, VALUES would not provide the schema type
> at the planning time; schema has to be propagate during execution time.
> We should allow ReduceExpressionRule extensible so that different behavior
> would be allowed to handle false filter in both schema-aware case and
> schema-on-read case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
