[
https://issues.apache.org/jira/browse/CALCITE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser resolved CALCITE-1040.
---------------------------------
Resolution: Fixed
Fixed in
https://git-wip-us.apache.org/repos/asf?p=calcite.git;a=commit;h=942693e67d1916264c98e0e803040e7f1f4311e3
Took the high path and made sure that, when present, we still do the same
(busted) parsing on the protobuf. This should make sure that we don't break 1.6
clients talking to 1.5 servers (the big reason we went protobuf to start).
Included tests for the 'old style' records, as well as added some arrays being
serialized/deserialized to make sure they were still working correctly.
Docs also included (will probably just wait for the 1.6.0 release to happen
instead of updating immediately). {{scalar_value}} will be set when the column
is a scalar, and {{array_value}} when it's an array.
> ColumnValue and TypedValue are unnecessarily both repeated
> ----------------------------------------------------------
>
> Key: CALCITE-1040
> URL: https://issues.apache.org/jira/browse/CALCITE-1040
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Affects Versions: 1.5.0
> Reporter: Carter Shanklin
> Assignee: Josh Elser
> Fix For: 1.6.0
>
>
> [~cartershanklin] sent me some nice notes from working on a Python interface
> to the Phoenix QueryServer. He saw this strange thing in the code he had to
> write:
> {code}
> count = response.results[0].first_frame.rows[0].value[0].value[0].number_value
> {code}
> The {{value\[0\].value\[0\]}} is strange. Looking at the protobuf definition,
> it seems like both {{ColumnValue}} and {{TypedValue}} are repeated which is
> causing this. Only one of them should be repeated, not both. This creates the
> equivalent of a 2dim array inside each row instead of just a 1dim array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
