[
https://issues.apache.org/jira/browse/CALCITE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094845#comment-15094845
]
Julian Hyde commented on CALCITE-978:
-------------------------------------
[~jaltekruse], I merged your patch and then revised so that it calls
builder.empty(). Please review:
https://github.com/julianhyde/calcite/commit/36ca8bcdc522f8e32c2310388d5eaf381dd594a1
If Drill overrides the {{createEmptyRelOrEquivalent}} methods it will work, but
at some point you I recommend that Drill overrides the {{RelBuilder.empty}}
method. Then all of the rules that create empty relational expressions will be
coming through the same point, and it will be doing the right thing for Drill.
And you can then remove your {{createEmptyRelOrEquivalent}} overrides.
> Make ReduceExpressionsRule extensible to transform false filter in
> schema-on-read case
> ---------------------------------------------------------------------------------------
>
> Key: CALCITE-978
> URL: https://issues.apache.org/jira/browse/CALCITE-978
> Project: Calcite
> Issue Type: Bug
> Reporter: Jinfeng Ni
> Assignee: Jason Altekruse
> Labels: drill
>
> This comes from a commit in Drill's forked Calcite
> (https://github.com/dremio/calcite/commit/a29f007f4f4017368b6f41bf8c3aba4490a1cee8).
> ReduceExpressionRule will transform a false filter into VALUES with empty
> input. This only works in the case of schema-aware scenario. In
> schema-on-read scenario like Drill, VALUES would not provide the schema type
> at the planning time; schema has to be propagate during execution time.
> We should allow ReduceExpressionRule extensible so that different behavior
> would be allowed to handle false filter in both schema-aware case and
> schema-on-read case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
