[ 
https://issues.apache.org/jira/browse/CALCITE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112661#comment-15112661
 ] 

Julian Hyde commented on CALCITE-528:
-------------------------------------

[~jnadeau], The natural thing is for the case-sensitivity policy to apply only 
to SQL and validation, not at the RelNode/RexNode level.

But it seems that Drill needs otherwise, so I suppose we can accommodate it. We 
could, say, put a "uniquifier" into the type factory.

> Creating output row type of a Join does not obey case-sensitivity flags
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-528
>                 URL: https://issues.apache.org/jira/browse/CALCITE-528
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 0.9.1-incubating
>            Reporter: Aman Sinha
>            Assignee: Julian Hyde
>
> In JoinRelBase.createJoinType() which creates a row type of the output row, a 
> HashSet of String is used to keep track of unique field names.  The field 
> names  'column1'  and 'Column1' will both be stored.   This creates a problem 
> for systems which are treating identifiers as case-insensitive (such as 
> Drill) which rely on a Project below a Join to create unique names if the 
> join columns are the same name (regardless of case).  
> Ideally, the comparison for this should be done based on the criteria 
> specified in the Lex settings when instantiating the 
> SqlParser.ParserConfigImpl.  So, if the parser was created with MYSQL Lex 
> settings (see Lex.java), it should be obeyed by the 
> JoinRelBase.createJoinType().  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to