[
https://issues.apache.org/jira/browse/CALCITE-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199125#comment-15199125
]
Jesus Camacho Rodriguez commented on CALCITE-1116:
--------------------------------------------------
[~julianhyde], thanks for the feedback. I agree, thus let's keep it on the safe
side and pass only "unknownAsFalse" through AND operators; then for e.g. NOT or
CASE, we will not pass the flag set to true. This will be safe, it will be
already useful and cover all cases we are currently targeting in Hive. In
future releases, we can revisit this issue if necessary, and extend simplify to
cover more cases.
I created a new pull request based on your commit (I saw you added some
comments, plus the flag renamed to "unknownAsFalse"), but in the new pull
request we only pass the parameter through AND operations. Could you please
pick up that one? Thanks!
> Extend simplify for reducing expressions
> ----------------------------------------
>
> Key: CALCITE-1116
> URL: https://issues.apache.org/jira/browse/CALCITE-1116
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Fix For: 1.7.0
>
>
> We would like to cover more cases in expression simplification, such as:
> x>5 and x is not null => x>5
> x>5 and x is null => not satisfiable
> x>5 and x<=5 => not satisfiable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
