[ 
https://issues.apache.org/jira/browse/CALCITE-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209294#comment-15209294
 ] 

Jacques Nadeau commented on CALCITE-1166:
-----------------------------------------

Have you found that Predicates perform the same as direct implementations? I'd 
guess they are slower.

> Disallow sub-classes of RelOptRuleOperand
> -----------------------------------------
>
>                 Key: CALCITE-1166
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1166
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> Disallow sub-classes of {{RelOptRuleOperand}}. The only reason that people 
> have sub-classed {{RelOptRuleOperand}} is to override the {{boolean 
> matches(RelNode)}} method, and you can now achieve that by supplying a 
> {{Predicate}} to the constructor.
> Next release, we will deprecate {{RelOptRuleOperand}}'s protected constructor 
> and create a new private or package-protected one. Later we will remove that 
> constructor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to