[
https://issues.apache.org/jira/browse/CALCITE-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262961#comment-15262961
]
Julian Hyde commented on CALCITE-1219:
--------------------------------------
The code looks OK.
Can you add a test case? For instance, does Drill's case treating a decimal
literal as a double apply to Calcite?
Can you review the javadoc related existing methods getOperandLiteralValue,
isOperandNull. These methods treat casted literals as if they were literals.
Should isOperandLiteral do the same?
> Add a method to SqlOperatorBinding to help determine if an operand is Literal
> or not
> ------------------------------------------------------------------------------------
>
> Key: CALCITE-1219
> URL: https://issues.apache.org/jira/browse/CALCITE-1219
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: Sean Hsuan-Yi Chu
> Assignee: Julian Hyde
>
> When Drill is doing type inference, a decimal {color:red} literal {color} can
> be treated as double in some cases.
> However, SqlOperatorBinding has not had a method to tell the caller if an
> operand is literal or not. This JIRA proposes adding such a helper method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
