[ 
https://issues.apache.org/jira/browse/CALCITE-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275702#comment-15275702
 ] 

Josh Elser commented on CALCITE-1232:
-------------------------------------

bq. Let me consult what the docs say

Well, the javadoc certainly don't give any implication that this should throw 
an error. We in Avatica can avoid making an RPC when the batch is empty which 
would be a nice improvement.

> AvaticaStatement should fail fast on executeBatch() if no statements are 
> present in the batch
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1232
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1232
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: avatica-1.8.0
>
>
> Ran into a little bug. I prepared a batch of updates via a PreparedStatement 
> but then accidentally called {{executeBatch()}} on another Statement object 
> which was currently in scope. This was causing my test to fail because it 
> appeared that there were no updates applied in the returned {{int[]}}.
> We should make {{executeBatch()}} on both {{AvaticaStatement}} and 
> {{AvaticaPreparedStatement}} fail with an exception if the current batch is 
> empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to