Duo Xu created CALCITE-1243:
-------------------------------
Summary: max_row_count in Proto file should be signed int
Key: CALCITE-1243
URL: https://issues.apache.org/jira/browse/CALCITE-1243
Project: Calcite
Issue Type: Bug
Reporter: Duo Xu
Assignee: Julian Hyde
Looking at the source code, the maxRowCount is signed. And based on the code
comments,
/** Creates a result set with maxRowCount.
*
* <p>If {@code maxRowCount} is -2 ({@link JdbcMeta#UNLIMITED_COUNT}),
* returns an unlimited number of rows in a single frame; any other
* negative value (typically -1) returns an unlimited number of rows
* in frames of the default frame size. */
we can pass -2 to return all the rows in a single batch. But the proto file
define this parameter as unsigned. We need to make it consistent with the
internal code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
