[ 
https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289879#comment-15289879
 ] 

Venki Korukanti commented on CALCITE-1241:
------------------------------------------

I think it makes sense to have a test in Calcite to check for new keywords and 
throw error if the test keyword list is not updated or forgot to add the new 
keywords to non-reserved keyword list. Testing the extended parsers is 
difficult unless they have their own tests which extend the list provided in 
the Calcite test. We can make the test code in extended parser smaller by 
providing the calcite keyword list. Let me know if you want the test with the 
patch.

> Add a freemarker variable for adding non reserved keywords to Parser.jj 
> template
> --------------------------------------------------------------------------------
>
>                 Key: CALCITE-1241
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1241
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Venki Korukanti
>            Assignee: Julian Hyde
>             Fix For: 1.8.0
>
>
> Currently Calcite parser allows customizing parser grammar for supporting new 
> Sql constructs (ex. {{SHOW TABLES}} or {{CREATE TABLE ... AS QUERY}}) through 
> freemarker template variables. There is a freemarker template variable to 
> allow new keywords, but all these keywords are added as reserved keywords 
> which are not allowed as identifiers unless escaped with {{`}} (or configured 
> casing character). 
> This JIRA is to add a freemarker template variable for adding non reserved 
> keywords list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to