[
https://issues.apache.org/jira/browse/CALCITE-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291158#comment-15291158
]
Josh Elser edited comment on CALCITE-1243 at 5/19/16 2:18 PM:
--------------------------------------------------------------
I was thinking about this one this morning. --It might be more clear to
actually implement this one alongside CALCITE-1242 (since we'd have to add a
new field to make sure we're backwards compatible for all languages protobuf
supports).--
Edit: I'm confusing things. I was actually thinking about another conversation
(not CALCITE-1242). We identified that it was confused that maxRowCount was
both treating as maximum number of rows for the statement as well as the
initial Frame size for PrepareAndExecuteRequest. It would be better to split
those up since we're touching things now.
was (Author: elserj):
I was thinking about this one this morning. It might be more clear to actually
implement this one alongside CALCITE-1242 (since we'd have to add a new field
to make sure we're backwards compatible for all languages protobuf supports).
> max_row_count in protobuf Requests should be signed int
> -------------------------------------------------------
>
> Key: CALCITE-1243
> URL: https://issues.apache.org/jira/browse/CALCITE-1243
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Duo Xu
> Assignee: Josh Elser
> Priority: Blocker
> Fix For: avatica-1.8.0
>
>
> Looking at the source code, the maxRowCount is signed. And based on the code
> comments,
> /** Creates a result set with maxRowCount.
> *
> * <p>If {@code maxRowCount} is -2 ({@link JdbcMeta#UNLIMITED_COUNT}),
> * returns an unlimited number of rows in a single frame; any other
> * negative value (typically -1) returns an unlimited number of rows
> * in frames of the default frame size. */
> we can pass -2 to return all the rows in a single batch. But the proto file
> define this parameter as unsigned. We need to make it consistent with the
> internal code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
