[
https://issues.apache.org/jira/browse/CALCITE-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser resolved CALCITE-1243.
---------------------------------
Resolution: Fixed
Fixed in
https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=987a257ae7cff588ac2f63518a7f75263a9bddb9
Will require a simple change in Calcite after this is released on
CalciteMetaImpl.
> max_row_count in protobuf Requests should be signed int
> -------------------------------------------------------
>
> Key: CALCITE-1243
> URL: https://issues.apache.org/jira/browse/CALCITE-1243
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Duo Xu
> Assignee: Josh Elser
> Priority: Blocker
> Fix For: avatica-1.8.0
>
>
> Looking at the source code, the maxRowCount is signed. And based on the code
> comments,
> /** Creates a result set with maxRowCount.
> *
> * <p>If {@code maxRowCount} is -2 ({@link JdbcMeta#UNLIMITED_COUNT}),
> * returns an unlimited number of rows in a single frame; any other
> * negative value (typically -1) returns an unlimited number of rows
> * in frames of the default frame size. */
> we can pass -2 to return all the rows in a single batch. But the proto file
> define this parameter as unsigned. We need to make it consistent with the
> internal code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
