[
https://issues.apache.org/jira/browse/CALCITE-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305036#comment-15305036
]
Julian Hyde commented on CALCITE-750:
-------------------------------------
Well, I can't deny that it works. But it's not ready to commit.
* Using mutable state in SqlBasicCall is messy and will cause re-entrancy
problems. Could you put that state in the visitor?
* '@return Void' is the most useless javadoc comment I've ever seen.
* You can remove most of the "[CALCITE-750] tags. We don't track individual
features in the source code. Just make comments where you need to clarify.
* It's pretty sloppy, frankly, that you have "[Calcite -750]" in one place and
and "[Caclite-750]" in another.
* In the test case, follow the convention in other test cases, and use a
hyperlink to the JIRA case.
* Don't remove the code from SqlValidatorTest, convert it from a negative to
positive test case.
> Window aggregate on top of a regular aggregate expression fails
> ---------------------------------------------------------------
>
> Key: CALCITE-750
> URL: https://issues.apache.org/jira/browse/CALCITE-750
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.3.0-incubating
> Reporter: Aman Sinha
> Assignee: Gautam Kumar Parai
>
> Window aggregate on top of a regular aggregate expression is a valid query
> but currently fails with a 'aggregate expression cannot be nested' error.
> {code}
> SELECT avg(sum(sal)) over (partition by deptno) from emp group by deptno;
> SEVERE: org.apache.calcite.sql.validate.SqlValidatorException: Aggregate
> expressions cannot be nested
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
