[
https://issues.apache.org/jira/browse/CALCITE-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336371#comment-15336371
]
Julian Hyde commented on CALCITE-1298:
--------------------------------------
It looks as if the performance difference will be minimal. Joiner does an extra
object creation and some virtual calls but I think they'll be inlined away.
Don't remove; mark deprecated, to be removed before 2.0.
I think Util.sepList and Util.commaList can be replaced with Joiner, too.
And can you get rid of Util.isNullOrEmpty. It encourages people to use nulls
and empty strings interchangeably, which is a bad habit. It's only used in 3
places.
> Consider removing Util.toString
> -------------------------------
>
> Key: CALCITE-1298
> URL: https://issues.apache.org/jira/browse/CALCITE-1298
> Project: Calcite
> Issue Type: Improvement
> Reporter: Michael Mior
> Assignee: Julian Hyde
> Priority: Minor
>
> {{Util.toString}} seems unnecessary in light of
> {{com.google.common.base.Joiner}}. There are ~16 total usages of this across
> the entire code base. One inside {{SubstitutionVisitor}} and the rest
> scattered around the Mongo, Cassandra, and Elasticsearch adapters. If there
> are no objections, I'll remove this and replace with {{Joiner}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
