[ 
https://issues.apache.org/jira/browse/CALCITE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337651#comment-15337651
 ] 

Julian Hyde commented on CALCITE-1297:
--------------------------------------

You're right. I didn't mean to duplicate the code. I think I introduced it 
while merging CALCITE-816.

In 
https://github.com/apache/calcite/commit/b5b28f0b2d263a2e2fb6894d67c8666549f4d053,
 I should have added a test case to RelBuilderTest, and the merge error would 
have been spotted.

The changes I was talking about making to {{field(int, int, String)}} would go 
further. We'd never create an identity project, even if the fields were 
different. We'd get the "virtual" row type from the Frame data structure, not 
call RelNode.getRowType(), and the virtual row type would have the field names 
that were just projected by the user.

> RelBuilder does not translate identity projects even if they rename fields
> --------------------------------------------------------------------------
>
>                 Key: CALCITE-1297
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1297
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.8.0
>            Reporter: Jark Wu
>            Assignee: Julian Hyde
>             Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to