[
https://issues.apache.org/jira/browse/CALCITE-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338168#comment-15338168
]
Michael Mior commented on CALCITE-1298:
---------------------------------------
Deprecated all but {{Util.isNullOrEmpty}} so far. In the three cases I think
it's reasonable to use {{value && value.length() > 0}}. As for
{{Util.sepList}}, it did have special cases for 0 and 1 elements which could
make things a bit more efficient but presumably it won't be be a huge source of
overhead.
> Deprecate little-used Util functions
> ------------------------------------
>
> Key: CALCITE-1298
> URL: https://issues.apache.org/jira/browse/CALCITE-1298
> Project: Calcite
> Issue Type: Improvement
> Reporter: Michael Mior
> Assignee: Julian Hyde
> Priority: Minor
>
> {{Util.toString}} seems unnecessary in light of
> {{com.google.common.base.Joiner}}. There are ~16 total usages of this across
> the entire code base. One inside {{SubstitutionVisitor}} and the rest
> scattered around the Mongo, Cassandra, and Elasticsearch adapters. If there
> are no objections, I'll remove this and replace with {{Joiner}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
