[
https://issues.apache.org/jira/browse/CALCITE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350540#comment-15350540
]
zhen wang commented on CALCITE-1227:
------------------------------------
[~julianhyde] I took a careful look at your work. looks all good and fits my
original target. two points of comparison with mine:
1. I was supposed to come up with your `cancel` mechanism design. I think where
the `cancel` flag is put currently fits my original thoughts. and I think my
problem is : although I know where it belongs to , I can't seem to hook all
critical components up as how it looks currently.
2. how the `cancel` is checked, my imp used "null" return to indicating a
`cancellation` of the execution. which is a bit confusing.
all in all, learned a lot in your fix. I'm all good with your change.
> Add streaming CSV table
> -----------------------
>
> Key: CALCITE-1227
> URL: https://issues.apache.org/jira/browse/CALCITE-1227
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
>
> Add a variant of CsvTable that can be streamed. It would serve as an example
> of how to write stream adapters.
> It would be like the CSV adapter, but watches a file and reports records
> added to the end of the file (like the tail command).
> You’d have to change {{CsvTable}} to implement {{StreamableTable}}, and
> implement the {{Table stream()}} method to return a variant of the table that
> is in “follow” mode.
> It would probably be implemented by a variant of CsvEnumerator, but it is
> getting its input in bursts, as the file is appended to.
> You would still be able to use this adapter to read historical data from the
> CSV file. Appending records to the file would make a nice demo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
