[
https://issues.apache.org/jira/browse/CALCITE-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390154#comment-15390154
]
Julian Hyde edited comment on CALCITE-1321 at 7/22/16 8:38 PM:
---------------------------------------------------------------
I'm not really sure whether I prefer a planner rule or a config. Planner rule
is quite a lot more work, obviously. This patch looks like it's heading in the
right direction, so let's go the config route for now.
The revised code looks better, because there's less code! You can remove a lot
more by adding a method {{withConfig}} to {{Sql}} and removing the method
{{convertsTo(String plan, SqlToRelConverter.Config config)}}.
Please deprecate the old SqlToRelConverter constructor, and remove 2 of the 3
SqlToRelConverterTest.assertConvertsTo methods.
Remove all of the config fields in SqlToRelConverter (e.g.
{{inSubqueryThreshold}}), and deprecate their accessor methods (e.g.
{{getInSubqueryThreshold}}). Add a public final Config field.
Also, a couple of slips:
* Not "SQLToRelConverter", but "SqlToRelConverter".
* "Called by builder; all values are in private final fields." is a good idea.
Make it so.
Continuation indent 4, not 8.
was (Author: julianhyde):
I'm not really sure whether I prefer a planner rule or a config. Planner rule
is quite a lot more work, obviously.
The revised code looks better, because there's less code! You can remove a lot
more by adding a method {{withConfig}} to {{Sql}} and removing the method
{{convertsTo(String plan, SqlToRelConverter.Config config)}}.
Please deprecate the old SqlToRelConverter constructor, and remove 2 of the 3
SqlToRelConverterTest.assertConvertsTo methods.
Remove all of the config fields in SqlToRelConverter (e.g.
{{inSubqueryThreshold}}), and deprecate their accessor methods (e.g.
{{getInSubqueryThreshold}}). Add a public final Config field.
Also, a couple of slips:
* Not "SQLToRelConverter", but "SqlToRelConverter".
* "Called by builder; all values are in private final fields." is a good idea.
Make it so.
Continuation indent 4, not 8.
> In-list to join optimization should have configurable in-list size
> -------------------------------------------------------------------
>
> Key: CALCITE-1321
> URL: https://issues.apache.org/jira/browse/CALCITE-1321
> Project: Calcite
> Issue Type: Bug
> Reporter: Gautam Kumar Parai
> Assignee: Gautam Kumar Parai
>
> We current have a default in-list size of 20. Instead of the magic number 20,
> we should make this configurable.
> {code}
> select count(*) from table where col in
> (1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
