[
https://issues.apache.org/jira/browse/CALCITE-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402885#comment-15402885
]
Julien Le Dem commented on CALCITE-1336:
----------------------------------------
Do you mean to leave the signature unchanged and change schemaPath to have the
view name as the last element?
Wouldn't that be a change of behavior that could break existing code?
I have a patch for adding the viewName parameter to the signature.
I think it is fine to allow viewName to be null.
> Add view name to the ViewExpander
> ---------------------------------
>
> Key: CALCITE-1336
> URL: https://issues.apache.org/jira/browse/CALCITE-1336
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Julien Le Dem
> Assignee: Julian Hyde
>
> The ViewExpander.expandView() call already has the schema path that contains
> the view but not the view name itself.
> In some context it is useful to also know the name of the view being expanded.
> current call:
> {code}
> RelRoot expandView(
> RelDataType rowType,
> String queryString,
> SchemaPlus rootSchema,
> List<String> schemaPath);
> {code}
> proposed:
> {code}
> RelRoot expandView(
> RelDataType rowType,
> String queryString,
> SchemaPlus rootSchema,
> List<String> schemaPath,
> String viewName);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
